[Whonix-devel] #25140 [Core Tor/Tor]: Parse only .torrc files in torrc.d directory

Mon Apr 23 12:37:49 CEST 2018

#25140: Parse only .torrc files in torrc.d directory
---------------------------------+------------------------------------
 Reporter:  iry                  |          Owner:  Jigsaw52
     Type:  task                 |         Status:  needs_revision
 Priority:  High                 |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor         |        Version:  Tor: 0.3.3.1-alpha
 Severity:  Major                |     Resolution:
 Keywords:  034-triage-20180328  |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:  ahf                  |        Sponsor:
---------------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => needs_revision

Comment:

 - `3ca5f8173298a4fa3bda6c5c3c3da528fc7cf85a`: Looks fine to me.
 - `edd70916b66fca41fc8aab10893ba731c1b75840`:
     1. Would it make sense to ensure that the `tor_glob()` function works
 the same way on both Windows and POSIX when glob'ing on directory and
 file? A part of the glob test case is split between Windows and POSIX
 there.
 - `5aec94bc3bb6623bd8f62aedeca8aaf699a0e8b6`:
     1. In `config_get_file_list()`: Why must the `matches` be sorted using
 `smartlist_sort_strings()`? Shouldn't that happen in the glob function
 then?
     2. I think `config_get_glob_opened_files()` might benefit from having
 some of this logic split into some more functions.
 - `15de04088b40efc85dc32f26fe7ec4a1abebb5d7`: Looks fine. Good with some
 documentation.

 Generally it looks good. It is very nice with a lot of tests for this
 code. Only concern for me is that there is some fairly big functions in
 this that I think could leverage from being split into smaller functions
 where possible.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25140#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online