[Whonix-devel] #18022 [Tor bundles/installation]: start-tor-browser.desktop parameter passing broken on spaces

Mon Jan 11 21:36:08 CET 2016

#18022: start-tor-browser.desktop parameter passing broken on spaces
--------------------------------------+-----------------------
 Reporter:  adrelanos                 |          Owner:  erinn
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Tor bundles/installation  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
  Sponsor:                            |
--------------------------------------+-----------------------

Comment (by cypherpunks):

 Replying to [comment:2 adrelanos]:
 > Likely the bug lies in:
 > https://gitweb.torproject.org/builders/tor-browser-
 bundle.git/tree/RelativeLink/execdesktop
 >
 > The following line seems wrong.
 >
 > {{{
 > eval "${TBB_START_PROG} $@"
 > }}}
 >
 > Replacing it with the following does the trick.
 >
 > {{{
 > eval "${TBB_START_PROG}" \'$@\'
 > }}}
 >
 > If that looks sane to you, could you please apply it to git?

 Wouldn't
 {{{
 eval "${TBB_START_PROG}" "${@}"
 }}}
 also work? It avoids escaping things which is ugly IMO.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18022#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online